Naming and coding style convention, new linter tool. (#945)
* Makefile, Scripts: new linter * About: remove ID from IC * Firmware: remove double define for DIVC/DIVR * Scripts: check folder names too. Docker: replace syntax check with make lint. * Reformat Sources and Migrate to new file naming convention * Docker: symlink clang-format-12 to clang-format * Add coding style guide
This commit is contained in:
@@ -33,8 +33,8 @@ RUN wget --progress=dot:giga "https://developer.arm.com/-/media/Files/downloads/
|
||||
RUN git clone --depth 1 --branch v0.4.1 https://github.com/atomicobject/heatshrink.git && \
|
||||
cd heatshrink && make && mv ./heatshrink /usr/local/bin/heatshrink
|
||||
|
||||
COPY entrypoint.sh syntax_check.sh /
|
||||
RUN ln -s `which clang-format-12` /usr/local/bin/clang-format
|
||||
|
||||
RUN chmod +x /syntax_check.sh
|
||||
COPY entrypoint.sh /
|
||||
|
||||
ENTRYPOINT ["/entrypoint.sh"]
|
||||
|
||||
@@ -1,42 +0,0 @@
|
||||
#!/usr/bin/env bash
|
||||
|
||||
# set -e
|
||||
|
||||
CLANG_FORMAT_BIN="/usr/bin/clang-format-12"
|
||||
|
||||
PROJECT_DIR=$(pwd)
|
||||
|
||||
cd "$PROJECT_DIR" || exit
|
||||
|
||||
echo "RUN C\C++ SYNTAX CHECK"
|
||||
C_FILES=$(find . \
|
||||
-not \( -path './firmware/.obj' -prune \) \
|
||||
-not \( -path './firmware/targets' -prune \) \
|
||||
-not \( -path './assets' -prune \) \
|
||||
-not \( -path ./lib -prune \) \
|
||||
-name *.c -o -name *.h -o -name *.cpp)
|
||||
|
||||
ulimit -s 65536
|
||||
$CLANG_FORMAT_BIN --version
|
||||
errors=$($CLANG_FORMAT_BIN --verbose -style=file -n --Werror --ferror-limit=0 $C_FILES |& tee /dev/stderr | sed '/^Formatting/d')
|
||||
|
||||
if [[ -z "$errors" ]]; then
|
||||
echo "Code looks fine for me!"
|
||||
exit 0
|
||||
fi
|
||||
|
||||
if [[ -n "${SET_GH_OUTPUT}" ]]; then
|
||||
errors="${errors//'%'/'%25'}"
|
||||
errors="${errors//$'\n'/'%0A'}"
|
||||
errors="${errors//$'\r'/'%0D'}"
|
||||
echo "::set-output name=errors::$errors"
|
||||
fi
|
||||
|
||||
read -p "Do you want fix syntax? (y/n): " confirm && [[ $confirm == [yY] || $confirm == [yY][eE][sS] ]] || exit 1
|
||||
|
||||
cd "$PROJECT_DIR" || exit
|
||||
|
||||
# We use root in container and clang-format rewriting files. We'll need change owner to original
|
||||
local_user=$(stat -c '%u' .clang-format)
|
||||
$CLANG_FORMAT_BIN -style=file -i $C_FILES
|
||||
chown $local_user $C_FILES
|
||||
Reference in New Issue
Block a user